Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: remove unused variables #1290

Closed
wants to merge 1 commit into from
Closed

lib: remove unused variables #1290

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Mar 28, 2015

No description provided.

@bnoordhuis
Copy link
Member

LGTM but I'm unclear on whether changes to streams code need to go through https://github.com/iojs/readable-stream now. /cc @chrisdickinson

@bnoordhuis
Copy link
Member

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/394/

@mscdex
Copy link
Contributor Author

mscdex commented Mar 29, 2015

The last I heard they are still pulling from this repo.

mscdex added a commit that referenced this pull request Mar 31, 2015
@mscdex
lib: remove unused variables
4dc6ae2 
PR-URL: #1290
Reviewed-By: Ben Noordhuis <[email protected]>
@mscdex
Copy link
Contributor Author

mscdex commented Mar 31, 2015

Landed in 4dc6ae2.

@mscdex mscdex closed this Mar 31, 2015
@mscdex mscdex deleted the lint branch March 31, 2015 20:02
@Fishrock123 Fishrock123 mentioned this pull request Apr 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mscdex @bnoordhuis