debugger: don't spawn child process in remote mode #1282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @bnoordhuis , would you like to review this patch? this pull request fix issue #889 . |
| if (connectionAttempts >= 10) { | ||
| client.removeListener('error', connectError); | ||
| self.stdout.write(' failed, please retry\n'); | ||
| return; | ||
| } | ||
| setTimeout(attemptConnect, 500); |
There was a problem hiding this comment.
Typo? attemptConnect is called connect now, I think?
There was a problem hiding this comment.
Not typo. attemptConnect is called, but failed.
JacksonTian
force-pushed
the
iojs_debuggger
branch
2 times, most recently
from
94d3bab to
88267eb
Compare
|
ping @bnoordhuis , I have updated by you comments. |
|
LGTM but would it be possible to add a regression test for #889? |
When debug in remote mode with host:port or pid, the interface
spawn child process also. If the debugger agent is running, will
get following output:
```
< Error: listen EADDRINUSE :::5858
< at Object.exports._errnoException (util.js:734:11)
< at exports._exceptionWithHostPort (util.js:757:20)
< at Agent.Server._listen2 (net.js:1155:14)
< at listen (net.js:1181:10)
< at Agent.Server.listen (net.js:1268:5)
< at Object.start (_debug_agent.js:21:9)
< at startup (node.js:68:9)
< at node.js:799:3
```
This fix won't spawn child process and no more error message was
shown.
When use `iojs debug`, the tip information just like this:
```
Usage: iojs debug script.js
```
This fix will display the advance usage also:
```
Usage: iojs debug script.js
iojs debug <host>:<port>
iojs debug -p <pid>
```
JacksonTian
force-pushed
the
iojs_debuggger
branch
from
88267eb to
e4180be
Compare
|
@bnoordhuis done. |
bnoordhuis
pushed a commit
that referenced
this pull request
Mar 27, 2015
When debug in remote mode with host:port or pid, the interface
spawn child process also. If the debugger agent is running, will
get following output:
```
< Error: listen EADDRINUSE :::5858
< at Object.exports._errnoException (util.js:734:11)
< at exports._exceptionWithHostPort (util.js:757:20)
< at Agent.Server._listen2 (net.js:1155:14)
< at listen (net.js:1181:10)
< at Agent.Server.listen (net.js:1268:5)
< at Object.start (_debug_agent.js:21:9)
< at startup (node.js:68:9)
< at node.js:799:3
```
This fix won't spawn child process and no more error message was
shown.
When use `iojs debug`, the tip information just like this:
```
Usage: iojs debug script.js
```
This fix will display the advance usage also:
```
Usage: iojs debug script.js
iojs debug <host>:<port>
iojs debug -p <pid>
```
Fixes: #889
PR-URL: #1282
Reviewed-By: Ben Noordhuis <[email protected]>
|
Excellent, thanks. Landed in a2ea168. I changed the test a little to use process.execPath instead of ./node. Thanks again. |
|
We still experience the issue angular/protractor#2039 |
|
@melnikaite Can you file a new issue and include a small test case or steps to reproduce? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debug in remote mode with host:port or pid, the interface
spawn child process also. If the debugger agent is running, will
get following output:
This fix won't spawn child process and no more error message was
shown.
When use
iojs debug, the tip information just like this:This fix will display the advance usage also: