deps: upgrade v8 to 4.1.0.25 #1224
Conversation
|
LGTM. What does CI say? |
| @@ -45,6 +45,7 @@ Jan de Mooij <[email protected]> | |||
| Jay Freeman <[email protected]> | |||
| James Pike <[email protected]> | |||
| Joel Stanley <[email protected]> | |||
| Johan Bergström <[email protected]> | |||
|
LGTM but I'd love to know what this includes other than the Solaris stuff, for instance what's the story with the changes in hydrogen-check-elimination.cc? Is there anything we can say about this in "notable items" in a release other than Solaris? |
|
@rvagg here's all commits. Nothing overly exciting, but at least makes us carry two less commits: v8/v8@4.1.0.21...4.1.0.25 |
|
LGTM but did you fold a558cd0 into the upgrade commit? I suppose that could cause some confusion for people that don't know we're floating that patch.
It fixes a type transition bug that results in a crash when the function gets optimized. It's possibly exploitable although it's probably very hard to exploit remotely. |
|
@bnoordhuis I based the patch on the diff between 21..25 which didn't touch |
No need, I think. I was just pleasantly surprised there was less churn than I expected. :-) |
PR-URL: #1224 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Merged in fe4434b. Thanks for helping out with the review! |
4.1.0.21..4.1.0.25 contains two of the patches we were floating (solaris build fix and heap size). PTAL since this is the "first time" I'm upgrading v8.
R=@indutny, @bnoordhuis