Upgrade to openssl101m #1206
Closed
Upgrade to openssl101m #1206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All sources are just extracted from tarball into deps/openssl/openssl.
change all openssl/include/openssl/*.h to include resolved symbolic links and openssl/crypto/opensslconf.h to refer config/opensslconf.h
sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length.
`x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 .
It is no longer used.
deps/openssl/asm/x64-win32-masm/x86_64cpuid.asm.orig was accidentally committed before.
|
cc @iojs/crypto @chrisdickinson |
|
There is no vulnerabilities of high severity on 1.0.1m except FREAK that was already fixed. So it need not to be so much in hurry to be released. |
shigeki
added
tls
|
OK, going to merge this and start the release. |
shigeki
pushed a commit
that referenced
this pull request
Mar 19, 2015
All sources are just extracted from tarball into deps/openssl/openssl. change all openssl/include/openssl/*.h to include resolved symbolic links and openssl/crypto/opensslconf.h to refer config/opensslconf.h sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686. removed vpaesni-x86_64.asm in x64-win32-masm - it is no longer used. Fixes: #1186 PR-URL: #1206 Reviewed-By: Fedor Indutny <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
|
Merged in a84ea66. Thanks! |
|
Great work. |
jasnell
added a commit
to jasnell/node-joyent
that referenced
this pull request
Mar 20, 2015
There are several updates pulled from: nodejs/node#1206 1. Expand the distribution tarball into deps/openssl/openssl 2. replace all headers in openssl change all openssl/include/openssl/*.h to include resolved symbolic links and openssl/crypto/opensslconf.h to refer config/opensslconf.h 3. deps: separate sha256/sha512-x86_64.pl for openssl sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. 4. fix openssl assembly error on ia32 win32 `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . 5. remove vpaesni-x86_64.asm in x64-win32-masm It is no longer used. 6. remove unused backup file in openssl asm deps/openssl/asm/x64-win32-masm/x86_64cpuid.asm.orig was accidentally committed before. 7. fix keypress requirement in apps on win32 reapply b910613
jasnell
added a commit
to jasnell/node-joyent
that referenced
this pull request
Mar 20, 2015
There are several updates pulled from: nodejs/node#1206 1. Expand the distribution tarball into deps/openssl/openssl 2. replace all headers in openssl change all openssl/include/openssl/*.h to include resolved symbolic links and openssl/crypto/opensslconf.h to refer config/opensslconf.h 3. deps: separate sha256/sha512-x86_64.pl for openssl sha256-x86_64.pl does not exist in the origin openssl distribution. It was copied from sha512-x86_64.pl and both sha256/sha512 scripts were modified so as to generates only one asm file specified as its key hash length. 4. fix openssl assembly error on ia32 win32 `x86masm.pl` was mistakenly using .486 instruction set, why `cpuid` (and perhaps others) are requiring .686 . 5. remove vpaesni-x86_64.asm in x64-win32-masm It is no longer used. 6. remove unused backup file in openssl asm deps/openssl/asm/x64-win32-masm/x86_64cpuid.asm.orig was accidentally committed before. 7. fix keypress requirement in apps on win32 reapply b910613
This was referenced Mar 20, 2015
This was referenced Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the PR to update openssl-1.0.1m based on the commits on #1186.
I've made 2 new commits below from #1186
d80e3b6 deps: upgrade to openssl-1.0.1m( just extract tarball)
a3be06e deps: replace all headers in openssl
The following 5 commits are cherry-picked from the branch that has already been reviewed in #1186
edc96eb deps: separate sha256/sha512-x86_64.pl for openssl
ac89f8a deps: fix openssl assembly error on ia32 win32
9985ff6 deps: remove vpaesni-x86_64.asm in x64-win32-masm
a263eb1 deps: remove unused backup file in openssl asm
a3e0da2 openssl: fix keypress requirement in apps on win32
There is no updates of
deps/openssl/openssl/crypto/sha/asm/sha512-x86_64.plsince #1186 and generating asm files has no diff.CI of https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/345/ is fine with known failures on Win, armv6 and armv8.
Please review this.