test: double timeout in tls-wrap-timeout.js #1201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test is timing dependent, ensure that it won't fail on the busy CI boxes. Fix: nodejs#1200
|
cc @jbergstroem |
|
fwiw I've tried to make it so that only one CI run is being done on a single box at a time, the only exception being the containers jobs but they aren't in this mix yet |
|
I think the only timeout you need to raise is the connecting socket. Anyway, you got my LGTM since it'll fix the problem. |
indutny
added a commit
that referenced
this pull request
Mar 19, 2015
The test is timing dependent, ensure that it won't fail on the busy CI boxes. Fix: #1200 PR-URL: #1201 Reviewed-By: Johan Bergström <[email protected]>
|
Landed in 3038b8e, thank you! |
This was referenced Apr 24, 2023
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is timing dependent, ensure that it won't fail on the busy CI
boxes.
Fix: #1200