build: remove incorrect arg in vcbuild.bat #1198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ouch! I was messing with that locally but it looks like it slipped in |
|
lgtm btw, |
now
|
I'll land after the CI runs on windows. |
|
@rvagg No timeouts on both windows machines! @mathiask88 thanks again for finding this! |
Fishrock123
force-pushed
the
fix-vcbuild.bat-timeout
branch
from
66b57a6 to
ff57cb9
Compare
This change had been incorrectly committed in f19e9b6 Reviewed-By: Rod Vagg <[email protected]>
Fishrock123
force-pushed
the
fix-vcbuild.bat-timeout
branch
from
ff57cb9 to
7d65d9a
Compare
Fishrock123
added a commit
to Fishrock123/node
that referenced
this pull request
Mar 19, 2015
This change had been incorrectly committed in f19e9b6 PR-URL: nodejs#1198 Reviewed-By: Rod Vagg <[email protected]>
This was referenced Apr 24, 2023
This was referenced Apr 26, 2023
This was referenced Apr 27, 2023
This was referenced Jul 8, 2023
This was referenced Nov 30, 2023
This was referenced Nov 30, 2023
This was referenced Dec 1, 2023
This was referenced Dec 2, 2023
This was referenced Dec 2, 2023
This was referenced Dec 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was wrongly committed in f19e9b6
R=@rvagg