tls_wrap: proxy handle methods in prototype #1108
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set proxied methods wrappers in `TLSWrap` prototype instead of doing it on every socket allocation. Should speed up things a bit and will certainly make heapsnapshot less verbose.
|
cc @iojs/collaborators too |
|
CI: good |
| if (this._parent[name]) | ||
| return this._parent[name].apply(this._parent, arguments); | ||
| }; | ||
| }); |
There was a problem hiding this comment.
do we care about the extra performance lost to creating a closure and referring to the call as this._parent[name] instead of this._parent.<name>?
There was a problem hiding this comment.
Nope, it shouldn't be critical here.
|
The change looks good. Just have a question. |
|
I see there is one TLS test failing on Windows but I'm not sure if it's related to this change... |
|
3 failures on windows are persistent and I don't believe they are related to this |
|
I checked previous runs and parallel/test-tls-over-http-tunnel seems to be failing consistently (and it's always the same 3 or 4 tests that fail.) LGTM then. |
indutny
added a commit
that referenced
this pull request
Mar 9, 2015
Set proxied methods wrappers in `TLSWrap` prototype instead of doing it on every socket allocation. Should speed up things a bit and will certainly make heapsnapshot less verbose. PR-URL: #1108 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Trevor Norris <[email protected]>
|
Landed in 8431fc5, thank you everyone! |
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set proxied methods wrappers in
TLSWrapprototype instead of doing iton every socket allocation. Should speed up things a bit and will
certainly make heapsnapshot less verbose.
cc @iojs/crypto