build: remove mdb from io.js #1023
Conversation
After upgrading to a newer v8 mdb is pretty much broken - even if using the latest updates from nodejs. If nodejs decides to update their v8 we can give it another go, but for now it's better to remove it than have it in our tree unsupported.
|
My suggestion to @jbergstroem was to gut this and if it needs to come back then Joyent is in a better position to do so and keep it updated. https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/224/ /R+=@bnoordhuis @indutny |
|
also LGTM as long as the other build slaves are OK with this too |
|
The smartos build slave is currently not building correcty, see upstream bug here: https://code.google.com/p/v8/issues/detail?id=3935 |
|
LGTM and I agree with the rationale. |
|
To get mdb rolling again is a fair amount of work. Needs to be synced against v8 which is a moving target. I spent some time on this before talking to @rvagg and made progress, but I wouldn't be able to shoulder maintaining it. It'd be better to get proper upstream (as in joyent or anyone else intersecting Illumos/v8) backing before reintroducing it. |
|
All good to merge? |
After upgrading to a newer v8 mdb is pretty much broken - even if using the latest updates from nodejs. If nodejs decides to update their v8 we can give it another go, but for now it's better to remove it than have it in our tree unsupported. PR-URL: #1023 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Rod Vagg <[email protected]>
|
Thanks Johan, landed in 37bb1df with the commit log wrapped at 72 columns. |
|
@bnoordhuis Thanks. Sorry about the commit text (esp the crypto test stuff). I'll fix my editor settings and improve from here on. |
|
@jbergstroem If it helps, I have |
(this is part of adding a smartos builder in our jenkins cluster)
After upgrading to a newer v8 mdb is pretty much broken - even if using the latest updates from nodejs. If nodejs decides to update their v8 we can give it another go, but for now it's better to remove it than have it in our tree unsupported.
/R=@rvagg, @geek