assert: don't compare object prototype property

All own enumerable properties are compared already. Comparing `prototype` property specifically can cause weird behaviour. PR-URL: #636 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Feb 6, 2015 · e7573f9 · e7573f9
1 parent 8d11799
commit e7573f9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/lib/assert.js b/lib/assert.js
@@ -186,8 +186,6 @@ function isArguments(object) {
 function objEquiv(a, b) {
   if (a === null || a === undefined || b === null || b === undefined)
     return false;
-  // an identical 'prototype' property.
-  if (a.prototype !== b.prototype) return false;
   // if one is a primitive, the other must be same
   if (util.isPrimitive(a) || util.isPrimitive(b))
     return a === b;

diff --git a/test/parallel/test-assert.js b/test/parallel/test-assert.js
@@ -130,7 +130,7 @@ assert.doesNotThrow(makeBlock(a.deepEqual, nb1, nb2));
 
 nameBuilder2.prototype = Object;
 nb2 = new nameBuilder2('Ryan', 'Dahl');
-assert.throws(makeBlock(a.deepEqual, nb1, nb2), a.AssertionError);
+assert.doesNotThrow(makeBlock(a.deepEqual, nb1, nb2));
 
 // primitives and object
 assert.throws(makeBlock(a.deepEqual, null, {}), a.AssertionError);