-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
blog: unit testing framework lfx blog #117
blog: unit testing framework lfx blog #117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits around. I'll make another round later on.
What about providing links to more unit tests implemented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments. I'll make a final pass once they're handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very good. Final nits. After that, I'll approve and merge on Monday.
5448092
to
1d0283e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I'll merge it on Monday (it's Friday late, so better to have it early next week)
Signed-off-by: mastersans <[email protected]>
Added LFX mentorship Blog.
cc @alban @mauriciovasquezbernal @mqasimsarfraz