Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: unit testing framework lfx blog #117

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

mastersans
Copy link
Contributor

Added LFX mentorship Blog.

cc @alban @mauriciovasquezbernal @mqasimsarfraz

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits around. I'll make another round later on.

What about providing links to more unit tests implemented?

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments. I'll make a final pass once they're handled.

Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very good. Final nits. After that, I'll approve and merge on Monday.

@mastersans mastersans force-pushed the lfx-blog branch 2 times, most recently from 5448092 to 1d0283e Compare December 6, 2024 16:51
Copy link
Member

@mauriciovasquezbernal mauriciovasquezbernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll merge it on Monday (it's Friday late, so better to have it early next week)

@mauriciovasquezbernal mauriciovasquezbernal merged commit 925c3bb into inspektor-gadget:main Dec 9, 2024
2 checks passed
@mastersans mastersans deleted the lfx-blog branch December 9, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants