oxidized-importer: support building on macOS

indygreg · indygreg · commit a42f98540960 · 2020-05-04T19:19:44.000-07:00
This required a cargo config file to make the linker happy. We also
had to teach setup.py about .dylib files. For convenience, we add
a script to build a wheel from macOS. Although I've only tested
this on my local machine, not in CI yet.

And minor changes to setup.py to find the Rust shared libraryu
diff --git a/ci/build-wheel-macos.sh b/ci/build-wheel-macos.sh
@@ -0,0 +1,8 @@
+#!/usr/bin/env bash
+# Script to build macOS binary wheel for oxidized_importer.
+
+set -exo pipefail
+
+export CIBW_BUILD=cp38-macosx_x86_64
+
+python3.8 -m cibuildwheel --output-dir wheelhouse --platform macos
diff --git a/oxidized-importer/.cargo/config b/oxidized-importer/.cargo/config
@@ -0,0 +1,7 @@
+# This is needed to avoid linking errors due to undefined symbols when
+# building Python extension modules.
+[target.x86_64-apple-darwin]
+rustflags = [
+  "-C", "link-arg=-undefined",
+  "-C", "link-arg=dynamic_lookup",
+]
diff --git a/setup.py b/setup.py
@@ -50,6 +50,8 @@ def build(self, build_dir: pathlib.Path, get_ext_path_fn):
 
         if os.name == "nt":
             rust_lib_filename = "%s.dll" % self.name
+        elif sys.platform == "darwin":
+            rust_lib_filename = "lib%s.dylib" % self.name
         else:
             rust_lib_filename = "lib%s.so" % self.name
 
