Fix state update to inactivate applets in live update #2902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2902 +/- ##
=======================================
Coverage 56.60% 56.60%
=======================================
Files 536 536
Lines 62548 62557 +9
Branches 7733 7733
=======================================
+ Hits 35405 35411 +6
- Misses 25360 25367 +7
+ Partials 1783 1779 -4 ☔ View full report in Codecov by Sentry. |
Also fixes downstream unreadiness in case of an untrained classifier. Fixes ilastik#1040
k-dominik
force-pushed
the
fix-oc-live
branch
from
d6cd335 to
5999523
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, in OC, one could activate all applets while on live update. This allowed to change the graph while training and could lead to #1040.
Also fixes downstream unreadiness in case of an untrained classifier.
Fixes #1040
previously - live update active
with this PR - live update active
Todos
ensure errors during batch processing don't block the UI--> will do this separately as it affects all workflows