Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

false positive on case folding match #55

Open
anewton1998 opened this issue Jul 2, 2024 · 0 comments
Open

false positive on case folding match #55

anewton1998 opened this issue Jul 2, 2024 · 0 comments

Comments

@anewton1998
Copy link
Contributor

The response matching algorithm for matching a response to a case-folded response does not appear to be taking into account certain behaviors that are RDAP legal. Without digging into the code, it looks like it could be caused by such things as:

{
  "title" : "REDACTED FOR PRIVACY",
  "type" : "object redacted due to authorization"
}

vs

{
  "type" : "object redacted due to authorization",
  "title" : "REDACTED FOR PRIVACY"
}

or it may be caused by the "self" link where the href and/or value may differ from the non case-folded version:

"links" : [
  {
    "href" : "https://rdap.nicenic.net/domain/oRbOpT.OrG",
    "rel" : "self",
    "type" : "application/rdap+json",
    "value" : "https://rdap.nicenic.net/domain/oRbOpT.OrG",
    "title" : "Authoritative URL for this resource"
  }
],

vs

"links" : [
  {
    "href" : "https://rdap.nicenic.net/domain/orbopt.org",
    "rel" : "self",
    "type" : "application/rdap+json",
    "value" : "https://rdap.nicenic.net/domain/orbopt.org",
    "title" : "Authoritative URL for this resource"
  }
],
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anewton1998