fix(C3DTFeature): use correct interleaved buffer getter #2326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Desplandis I assign it to you but maybe someone else could be more fitted to this MR. |
AnthonyGlt
force-pushed
the
fix/use-correct-getter-interleaved-buffer
branch
from
3397800
to
80ad0a1
Compare
Desplandis
approved these changes
Jul 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should use the getter of threejs to access position in buffer, especially when we have interleaved buffer
Motivation and Context
Similar to what was done in #2266
To note:
I encountered issues related to the batchtable, I wonder if there is some misconception in the treatment of it. I will try to investigate more