fix(view): fix view resize when width or height is 0

iTowns · Dec 8, 2022 · dbd9ee3 · dbd9ee3
1 parent cccacae
commit dbd9ee3
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 5 deletions.
diff --git a/src/Core/View.js b/src/Core/View.js
@@ -1088,6 +1088,11 @@ class View extends THREE.EventDispatcher {
      * the viewer with. By default it is the `clientHeight` of the `viewerDiv`.
      */
     resize(width, height) {
+        if (width < 0 || height < 0) {
+            console.warn(`Trying to resize the View with negative height (${height}) or width (${width}). Skipping resize.`);
+            return;
+        }
+
         if (width == undefined) {
             width = this.domElement.clientWidth;
         }
@@ -1098,8 +1103,10 @@ class View extends THREE.EventDispatcher {
 
         this.#fullSizeDepthBuffer = new Uint8Array(4 * width * height);
         this.mainLoop.gfxEngine.onWindowResize(width, height);
-        this.camera.resize(width, height);
-        this.notifyChange(this.camera.camera3D);
+        if (width !== 0 && height !== 0) {
+            this.camera.resize(width, height);
+            this.notifyChange(this.camera.camera3D);
+        }
     }
 }
 

diff --git a/src/Renderer/Camera.js b/src/Renderer/Camera.js
@@ -139,12 +139,16 @@ class Camera {
     }
 
     /**
-     * Resize the camera to a given width and height
+     * Resize the camera to a given width and height.
      *
-     * @param   {number}    width               The width to resize the camera to.
-     * @param   {number}    height              The height to resize the camera to.
+     * @param {number} width The width to resize the camera to. Must be strictly positive, won't resize otherwise.
+     * @param {number} height The height to resize the camera to. Must be strictly positive, won't resize otherwise.
      */
     resize(width, height) {
+        if (!width || width <= 0 || !height || height <= 0) {
+            console.warn(`Trying to resize the Camera with invalid height (${height}) or width (${width}). Skipping resize.`);
+            return;
+        }
         const ratio = width / height;
         if (this.camera3D.aspect !== ratio) {
             if (this.camera3D.isOrthographicCamera) {