fix(PointCloud): correct some issues after refacto

AnthonyGlt · Desplandis · commit 65c4008874d9 · 2024-04-30T10:28:39.000+02:00
diff --git a/examples/3dtiles_pointcloud.html b/examples/3dtiles_pointcloud.html
@@ -76,10 +76,8 @@
             itowns.View.prototype.addLayer.call(view, $3dTilesLayerSetePC);
             function switchMode(){
                 let pntsLayer = view.getLayerById("3d-tiles-sete");
-
                 if(pntsLayer){
-                    pntsLayer = pntsLayer;
-                    pntsLayer.pntsMode = pntsLayer.pntsMode == itowns.PNTS_MODE.COLOR ? itowns.PNTS_MODE.CLASSIFICATION : itowns.PNTS_MODE.COLOR;
+                    pntsLayer.pntsMode = pntsLayer.pntsMode === itowns.PNTS_MODE.COLOR ? itowns.PNTS_MODE.CLASSIFICATION : itowns.PNTS_MODE.COLOR;
                     view.notifyChange(view.camera3D);
                 }
             }
diff --git a/src/Parser/PntsParser.js b/src/Parser/PntsParser.js
@@ -135,6 +135,6 @@ function parseFeatureBinary(array, byteOffset, FTJSONLength) {
 
 function setClassification(point, batchTable) {
     if (!point.geometry) { return; }
-    if (batchTable.content && batchTable.content.Classification) { point.geometry.setAttribute('classification', new THREE.BufferAttribute(new Uint8Array(batchTable.content.Classification), 1, true)); }
+    if (batchTable.content && batchTable.content.Classification) { point.geometry.setAttribute('classification', new THREE.BufferAttribute(new Uint8Array(batchTable.content.Classification), 1)); }
     return point;
 }
diff --git a/src/Renderer/PointsMaterial.js b/src/Renderer/PointsMaterial.js
@@ -210,7 +210,7 @@ class PointsMaterial extends THREE.ShaderMaterial {
         delete options.elevationRange;
         delete options.angleRange;
         delete options.orientedImageMaterial;
-        delete options.classificationScheme;
+        delete options.classification;
         delete options.discreteScheme;
         delete options.applyOpacityClassication;
         delete options.size;

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,8 @@`
`76`	`76`	`itowns.View.prototype.addLayer.call(view, $3dTilesLayerSetePC);`
`77`	`77`	`function switchMode(){`
`78`	`78`	`let pntsLayer = view.getLayerById("3d-tiles-sete");`
`79`		`-`
`80`	`79`	`if(pntsLayer){`
`81`		`- pntsLayer = pntsLayer;`
`82`		`- pntsLayer.pntsMode = pntsLayer.pntsMode == itowns.PNTS_MODE.COLOR ? itowns.PNTS_MODE.CLASSIFICATION : itowns.PNTS_MODE.COLOR;`
	`80`	`+ pntsLayer.pntsMode = pntsLayer.pntsMode === itowns.PNTS_MODE.COLOR ? itowns.PNTS_MODE.CLASSIFICATION : itowns.PNTS_MODE.COLOR;`
`83`	`81`	`view.notifyChange(view.camera3D);`
`84`	`82`	`}`
`85`	`83`	`}`
Original file line number	Diff line number	Diff line change
`@@ -135,6 +135,6 @@ function parseFeatureBinary(array, byteOffset, FTJSONLength) {`
`135`	`135`
`136`	`136`	`function setClassification(point, batchTable) {`
`137`	`137`	`if (!point.geometry) { return; }`
`138`		`- if (batchTable.content && batchTable.content.Classification) { point.geometry.setAttribute('classification', new THREE.BufferAttribute(new Uint8Array(batchTable.content.Classification), 1, true)); }`
	`138`	`+ if (batchTable.content && batchTable.content.Classification) { point.geometry.setAttribute('classification', new THREE.BufferAttribute(new Uint8Array(batchTable.content.Classification), 1)); }`
`139`	`139`	`return point;`
`140`	`140`	`}`