Fix release script

hustcer · hustcer · commit d0971ed286f3 · 2024-10-25T16:06:12.000+08:00
diff --git a/Justfile b/Justfile
@@ -84,11 +84,11 @@ outdated:
   ncu
 
 # Release a new version for `setup-nu`
-release updateLog=('false'):
+release *OPTIONS:
   @overlay use {{ join(SETUP_NU_PATH, 'nu', 'common.nu') }}; \
     overlay use {{ join(SETUP_NU_PATH, 'nu', 'release.nu') }}; \
     git-check --check-repo=1 {{SETUP_NU_PATH}}; \
-    make-release --update-log={{updateLog}}
+    make-release {{OPTIONS}}
 
 # Plugins need to be registered only once after nu v0.61
 _setup:
diff --git a/nu/common.nu b/nu/common.nu
@@ -19,11 +19,14 @@ export def 'get-env' [
 }
 
 # Check if a git repo has the specified ref: could be a branch or tag, etc.
-export def 'has-ref' [
+export def has-ref [
   ref: string   # The git ref to check
 ] {
-  let parse = (git rev-parse --verify -q $ref)
-  if ($parse | is-empty) { false } else { true }
+  let checkRepo = (do -i { git rev-parse --is-inside-work-tree } | complete)
+  if not ($checkRepo.stdout =~ 'true') { return false }
+  # Brackets were required here, or error will occur
+  let parse = (do -i { git rev-parse --verify -q $ref } | complete)
+  if ($parse.stdout | is-empty) { false } else { true }
 }
 
 # Compare two version number, return `1` if first one is higher than second one,
diff --git a/nu/release.nu b/nu/release.nu
@@ -11,7 +11,7 @@
 # Usage:
 #   Change `actionVer` in package.json and then run: `just release` OR `just release true`
 
-export def 'make-release' [
+export def make-release [
   --update-log(-u),   # Set to `true` do enable updating CHANGELOG.md
 ] {
 
