Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated faiss_with_hf_datasets_and_clip.md to Korean #211

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Translated faiss_with_hf_datasets_and_clip.md to Korean #211

wants to merge 11 commits into from

Conversation

jeongiin
Copy link
Contributor

What does this PR do?

This is PR presents the korean translation of Embedding multimodal data for similarity search using 🤗 transformers, 🤗 datasets and FAISS cookbook.

Who can review?

@4N3MONE, @harheem, @boyunJang, @ahnjj, @SeungAhSon,@jun048098,@win2dvp21

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@merveenoyan
Copy link
Collaborator

@jeongiin 고맙습니다 once reviewed by other Korean speakers we can merge :)

@jun048098
Copy link
Contributor

LGTM! 번역 감사합니다!

@jeongiin jeongiin marked this pull request as ready for review October 27, 2024 06:31
boyunJang
boyunJang reviewed Oct 27, 2024
View reviewed changes
notebooks/ko/faiss_with_hf_datasets_and_clip.ipynb Show resolved Hide resolved
notebooks/ko/faiss_with_hf_datasets_and_clip.ipynb Show resolved Hide resolved
notebooks/ko/faiss_with_hf_datasets_and_clip.ipynb
@@ -0,0 +1,587 @@
{
Copy link

@boyunJang boyunJang Oct 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Line #2.    # 유사한 텍스트와 이미지를 확인합니다.


Reply via ReviewNB

notebooks/ko/faiss_with_hf_datasets_and_clip.ipynb
@@ -0,0 +1,587 @@
{
Copy link

@boyunJang boyunJang Oct 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Line #3.    # 다시 추론합니다.


Reply via ReviewNB

@boyunJang
Copy link

좀 많이 늦었지만...그리고 많이 고친 부분은 없지만 리뷰 남깁니다! 주석 한국어로 바꾸는 부분만 확인해보면 될 것 같아요!
쿡북 제작하느라 정말 수고하셨습니다!

@merveenoyan
Copy link
Collaborator

nice to translate the comments! @boyunJang
@jeongiin also thanks for picking this I wrote this recipe it makes me happy 😂
we made an org for cookbook authors, sort of like a badge on your profile if you request to join after this is merged: https://huggingface.co/huggingcooks

@merveenoyan
Copy link
Collaborator

There's an issue with the CI atm regarding rendering of Korean characters, CI gets stuck. we're waiting on our colleague to fix this. we'll merge afterwards

jeongiin
jeongiin commented Oct 31, 2024
View reviewed changes
notebooks/ko/_toctree.yml Outdated Show resolved Hide resolved
@jeongiin
Copy link
Contributor Author

@merveenoyan I'm glad I could contribute too!
Thank you for writing a great recipe :) It's really exciting to be able to receive a badge! I hope it merges!
Have a nice day 👍

@merveenoyan
Copy link
Collaborator

@jeongiin the issue with the CI was fixed, would you like to merge main into this branch, we can check if the CI passes and then merge this PR

@jeongiin
Copy link
Contributor Author

@merveenoyan Of course! I've been waiting for this! Please let me know if there's anything else I need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boyunJang boyunJang boyunJang left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeongiin @merveenoyan @jun048098 @boyunJang