Fix deprecation in routing #657
Merged
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
approved these changes
Aug 2, 2024
|
Can anyone please merge this PR? The Rails warning for that is really annoying. |
|
The deprecation is in a non-released version of Rails. There is no reason to rush maintainers because you are using a non-released version of the framework that can change at any time. |
brunoprietog
requested changes
Aug 6, 2024
There was a problem hiding this comment.
Hi @atomaka, thanks for your contribution! I left a very minor suggestion
Closed
Co-authored-by: Bruno Prieto <[email protected]>
Co-authored-by: Bruno Prieto <[email protected]>
|
Thanks @atomaka! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes new deprecation in Rails from rails/rails#52422 that marks paths as hash keys in routes for removal.