Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the rails turbo:install:redis rake task #223

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

alexandreruban
Copy link
Contributor

Broadcasting from the console to the browser is not possible with the default ActionCable Async adapter.
The installation guide should document the existance of the rails turbo:install:redis rake task and mention the limitations of the Async adapter.

@dhh
Copy link
Member

dhh commented Aug 26, 2021

Like this. The double CRs are otherwise intentional. Can you scrap those?

Also, we should be more forceful: If you're using Turbo Streams, you must turn on Redis. It basically doesn't work properly otherwise.

@alexandreruban
Copy link
Contributor Author

I added back the double CRs and removed the "Optional but recommended" at the beginning of the sentence.

@dhh dhh merged commit acad666 into hotwired:main Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants