Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: show warning for interceptors not supporting binary data #4566

Merged
merged 4 commits into from
Nov 27, 2024
Merged

chore: show warning for interceptors not supporting binary data #4566

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4bbd53f
chore: `supportsBinaryContentType` inspector warning for `native`, `a…
CuriousCorrelation Nov 27, 2024
4a93c2b
fix: inspector warning on supported interceptors
CuriousCorrelation Nov 27, 2024
03ec1f9
fix: consistent def impl for `binary` content type
CuriousCorrelation Nov 27, 2024
7b59ba5
chore: cleanup
jamesgeorge007 Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: consistent def impl for binary content type
  • Loading branch information
@CuriousCorrelation @jamesgeorge007
CuriousCorrelation authored and jamesgeorge007 committed Nov 27, 2024
commit 03ec1f9323ec328390410822ecc6b7c67aec457c
6 changes: 3 additions & 3 deletions packages/hoppscotch-common/src/services/interceptor.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,19 +104,19 @@ export type Interceptor<Err extends InterceptorError = InterceptorError> = {

/**
* Defines whether the interceptor has support for cookies.
* If this field is undefined, it is assumed as not supporting cookies.
* If this field is undefined, it is assumed as *not supporting* cookies.
*/
supportsCookies?: boolean

/**
* Defines whether the interceptor has support for Digest Auth.
* If this field is undefined, it is assumed as not supporting the Digest Auth type.
* If this field is undefined, it is assumed as *not supporting* the Digest Auth type.
*/
supportsDigestAuth?: boolean

/**
* Defines whether the interceptor has support for Binary (file) content type.
* If this field is undefined, it is assumed as not supporting the Binary content type.
* If this field is undefined, it is assumed as *supporting* the Binary content type.
*/
supportsBinaryContentType?: boolean

Expand Down
2 changes: 1 addition & 1 deletion packages/hoppscotch-selfhost-desktop/src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const headerPaddingTop = ref("0px")
{ type: "service", service: NativeInterceptorService },
{
type: "standalone",
interceptor: { ...proxyInterceptor, supportsDigestAuth: true, supportsBinaryContentType: true },
interceptor: { ...proxyInterceptor, supportsDigestAuth: true },
},
],
},
Expand Down