fix(agent): propagate default values to persistent store #4511
Conversation
There was a problem hiding this comment.
I'm not a Rust expert, but would replacing
let _ = store
.delete("registrations")
.then_some(())
.ok_or(AppError::RegistrationClearError)?;
with
if store.get("registrations").is_some() {
let _ = store
.delete("registrations")
.then_some(())
.ok_or(AppError::RegistrationClearError)?;
}
be a more robust fix?
There was a problem hiding this comment.
Thanks for the suggestions! It's actually a good catch and indeed part of a refactor I’m currently planning - essentially to have a more robust logging/tracing, error system and better error propagation.
The reason why I didn’t include that into the current fix was because the primary issue was uninitialized store since while the app assumed empty default store with
but didn’t translate/communicate that assumption to the disk.We can definitely include this fix into the PR as well, we’d basically use a match statement or even better - ? error propagation and then propagate that upwards from tray.rs + some tracing for the stacktrace.
CuriousCorrelation
force-pushed
the
agent/fix/persist-store
branch
2 times, most recently
from
178495e to
14a1455
Compare
AndrewBastin
force-pushed
the
agent/fix/persist-store
branch
from
43c7541 to
2a0a582
Compare
This PR fixes an issue where sane default values set in the ephemeral store were not being propagated to the persistent store if the store was uninitialized or encountered a loading error. Now, if the persistent store is absent or fails to load, default values will be established in the ephemeral store and subsequently saved to the persistent store, syncing two both storage layers.
Closes HFE-645