feat(filename): added filename in download functional #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivedin
requested changes
Sep 10, 2024
nivedin
force-pushed
the
file-with-name
branch
2 times, most recently
from
79076e6 to
dce67dd
Compare
|
@nivedin what do you think. Maybe we remove "Download file" button from packages/hoppscotch-common/src/components/http/ImportCurl.vue? |
|
@nivedin PR is done |
AndrewBastin
force-pushed
the
file-with-name
branch
from
515ff13 to
50684bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4265
What's changed
Added name for file in all useDownloadResponse methods
Notes to reviewers
Maybe we need to move file name in locale files?