-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import actions within the Import/Export
collections modal need a loading state
#4145
Comments
Hi, I wanna work on this, please assign me. I can't find the guide to set-up this repo locally |
Hi @kyoichishido, sorry for the delayed response. To reiterate, this is intended for FOSSHACK participants. Please make sure to register as a participant if you haven't already. You can find more information here. Follow the below steps to set up the repo locally.
You can get up and running quickly with the above steps. To enable any functionality behind login, you'll have to set up the backend container following the steps below.
Alternatively, you can use the AIO container which is a single container that provides all the services required to run Hoppscotch. P.S: Any updates locally will require rebuilding the AIO container. For development, the above approach where the FE dev server is spun up locally along with the backend container would suffice.
Let us know if you have any questions. |
I am participating in FOSS Hack where I have registered and joined a team. My initial approach for this is to set a flag that will disable the button and show a loading message while the async process is running. Once the process completes, the flag will be toggled back.Can this issue be assigned to me? |
Hi @HelixY2J, thanks for expressing interest. @kyoichishido, can you confirm if you've registered as a participant and like to pick this up? Else, this can be assigned to @HelixY2J. |
Assigning this to @HelixY2J. |
I created a reactive variable "isImporterInProgress "using Vue ref function and added it into the existing import logic in collections/importexport.vue. It will be set true when the import starts and reset to false after completion.Can I get some feedback on whether this approach is appropriate or there are any alternative methods that should be considered for handling the loading state |
Hi, a quick suggestion regarding the behaviour. It would be nice to have a loading spinner before the button label |
Import/Export
collections modal need a loading state
Implemented in #4217 and released as part of v2024.9.0. |
Note
This is intended for FOSSHACK participants.
Description
While importing a large collection in a team workspace, it'll be nice to have a loading state for the
Import
button while the network calls happen behind the scenes.import-collections-modal-loading-state-requirement.mov
The text was updated successfully, but these errors were encountered: