Skip to content

fix(serve-static): support Windows #3477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yusukebe merged 6 commits into from
Jul 14, 2025
Merged

fix(serve-static): support Windows #3477

yusukebe merged 6 commits into from
Jul 14, 2025

Conversation

@yusukebe
Copy link
Member

@yusukebe yusukebe commented Oct 1, 2024 •
edited
Loading

Fixes #3475
Fixes #3693

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@codecov
Copy link

codecov bot commented Oct 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.29%. Comparing base (09a81e4) to head (a9126d2).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3477      +/-   ##
==========================================
- Coverage   91.32%   91.29%   -0.03%     
==========================================
  Files         170      170              
  Lines       10812    10908      +96     
  Branches     3093     3168      +75     
==========================================
+ Hits         9874     9959      +85     
- Misses        937      948      +11     
  Partials        1        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yusukebe yusukebe mentioned this pull request Oct 30, 2024
Closed
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions
Copy link

github-actions bot commented Jul 3, 2025

Bundle size check

main (09a81e4) #3477 (917ed3b) +/-
Bundle Size (B) 18,206B 18,206B 0B
Bundle Size (KB) 17.78K 17.78K 0K

Compiler Diagnostics (tsc)

main (09a81e4) #3477 (917ed3b) +/-
Files 262 262 0
Lines 116,386 116,386 0
Identifiers 114,405 114,405 0
Symbols 259,899 259,899 0
Types 162,566 162,566 0
Instantiations 3,039,295 3,039,295 0
Memory used 273,450K 271,137K -2,313K
I/O read 0.02s 0.02s 0s
I/O write 0s 0s 0s
Parse time 0.91s 0.65s -0.26s
Bind time 0.29s 0.28s -0.01s
Check time 3.87s 3.7s -0.17s
Emit time 0s 0s 0s
Total time 5.07s 4.62s -0.45s

Compiler Diagnostics (typescript-go)

main (09a81e4) #3477 (917ed3b) +/-
Files 232 232 0
Lines 106,285 106,285 0
Identifiers 106,145 106,145 0
Symbols 371,531 371,531 0
Types 293,008 293,008 0
Instantiations 3,568,491 3,568,491 0
Memory used 229,700K 229,711K 11K
Memory allocs 10,003,575 10,003,500 -75
Parse time 0.067s 0.081s 0.014s
Bind time 0.016s 0.02s 0.004s
Check time 1.437s 1.575s 0.138s
Emit time 0s 0s 0s
Total time 1.522s 1.683s 0.161s

Reported by octocov

@github-actions
Copy link

github-actions bot commented Jul 3, 2025

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 38,497.59 52,335.58 33,987.71 29,169.48
hono (current) bun 38,019.25 51,476.40 33,539.97 29,041.38
Change -1.24% -1.64% -1.32% -0.44%

@yusukebe yusukebe changed the title [WIP] fix(serve-static): support Windows fix(serve-static): support Windows Jul 3, 2025
@yusukebe yusukebe marked this pull request as ready for review July 3, 2025 07:43
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jul 3, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hono@3477

commit: a9126d2

@yusukebe
Copy link
Member Author

yusukebe commented Jul 3, 2025 •
edited
Loading

Hi @oscarotero @dmytro-peleshenko

Sorry for being late! This RP may solve your problem. If you have time, can you try this branch to confirm it works well? You can install hono of this branch with the following command:

npm i https://pkg.pr.new/hono@3477

@usualoma (@ryuapp) I think this is okay. Can you review this?

@yusukebe yusukebe mentioned this pull request Jul 9, 2025
Closed
@yusukebe
Copy link
Member Author

yusukebe commented Jul 14, 2025

I think we can merge this. If you have any problems, please feel free to open an issue.

@yusukebe yusukebe merged commit 7ecf369 into main Jul 14, 2025
21 checks passed
@yusukebe yusukebe deleted the fix/serve-static-support-windows branch July 14, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cr-tracked

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

root option for serveStatic on Windows serveStatic root is incorrect on Windows + Bun for absolute path (other interpreters probably too)

2 participants

@yusukebe