Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add topology.kubernetes.io/zone #267

Closed
leszko opened this issue Oct 29, 2020 · 2 comments · Fixed by #268
Closed

Add topology.kubernetes.io/zone #267

leszko opened this issue Oct 29, 2020 · 2 comments · Fixed by #268
Milestone
2.2

Comments

@leszko
Copy link

leszko commented Oct 29, 2020

failure-domain.beta.kubernetes.io/zone is deprecated, we need to use topology.kubernetes.io/zone instead.

https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/
@bykrmci
Copy link

bykrmci commented Oct 30, 2020

  • label "failure-domain.beta.kubernetes.io/zone" should be maintained to grant backward compatibility with Kubernetes < 1.17 (and consequently Openshift < 4.4 )
  • label "failure-domain.kubernetes.io/zone" should be replaced by the label "topology.kubernetes.io/zone" to grant compliancy with Kubernetes >= 1.17 (and consequently Openshift 4.4+)

@leszko
Copy link
Author

leszko commented Oct 30, 2020

Yeah, I think to be backward-compatible we'll keep failure-domain.beta.kubernetes.io/zone (and probably also failure-domain.kubernetes.io/zone, because we've seen some clusters using it).

@leszko leszko mentioned this issue Oct 30, 2020
Merged
@leszko leszko added this to the 2.2 milestone Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2
Development

Successfully merging a pull request may close this issue.

Add extracting zone from node label: "topology.kubernetes.io/zone" leszko/hazelcast-kubernetes
2 participants
@leszko @bykrmci