-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quick approximation for map projections #922
Conversation
Instead of reprojecting everything, we just set the aspect ratio of the plot to the ratio between the length of one degree of lat over one degree of lon.
The latest version of roxygen figures out S3 methods on its own
Now passes |
@@ -0,0 +1,65 @@ | |||
#' Cartesian coordinates with an aspect ratio approximating mercator projection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Mercator?
|
I wonder if it's worth noting that it's hard to see the difference between the two plots of NZ not because it's at a moderate latitude, but because the base file is already very detailed. It might be worth plotting a rectangle bounding NZ to more clearly show the difference. |
I'm not sure it's about the details, it's really about the latitude and the extent of the region. Here is the code with a bounding box:
|
I meant a rectangular bb so that you could see the difference. NZ might be a bad example but it'd be nice to have one |
The difference is actually fairly small for anything under moderate latitudes. Even for the full US it's noticeable only for the northern states (that actually makes the functionality more appealing!). I guess it would show for northern canada or russia but this data is not in |
Would that be better?
But |
Yeah, doesn't seem to be an easy way to generate a nice example, so lets not worry about it. |
Great. Thanks for merging it! It'll be useful to be able to use this one for one class in which we produce a lot of tiled maps which |
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
Instead of reprojecting everything, we just set the aspect ratio of the plot
to the ratio between the length of one degree of lat over one degree of lon.
Edit on 2014-02-27: rebased on head + latest version of roxygen