Skip to content

Periodic orcid citation update failing due to approver requirements #71

@vincerubinetti

Description

@vincerubinetti

https://github.com/greenelab/greenelab.com/actions/runs/3819357107

remote: error: At least 1 approving review is required by reviewers with write access.

It makes sense that you'd want an approver for pull requests, but unfortunately that means the GitHub Action that periodically runs the automatic citation process to update e.g. ORCID papers will fail because it doesn't have permissions.

Apparently there is no way to make an exception for GitHub Actions (yet, but it is a heavily requested feature):
community/community#13836

I could maybe make it such that the action opens a PR instead of committing directly to main, but then I'd imagine them really piling up over time. Maybe I could try to check if a PR for that is already open and update/add to it instead of creating a new one, but that gets a lot more complex.

@cgreene Thoughts? I'm not just thinking about greenelab.com, but the template in general.

I'm thinking we just bet on GitHub implementing the Actions exception within the next year (since it's so heavily requested), and until then, say that people can't have both branch protection rules and scheduled action runs.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions