Fix issue StrictMode issue where dependencies are incorrectly updated

martinbooth · martinbooth · commit f71889ac3684 · 2025-01-01T21:48:26.000-08:00
diff --git a/packages/gl-react/src/Node.js b/packages/gl-react/src/Node.js
@@ -718,10 +718,10 @@ export default class Node extends Component<Props, *> {
     newdeps: Array<Node | Bus>
   ): [Array<Bus | Node>, Array<Bus | Node>] {
     const olddeps = this.dependencies;
-    const additions = newdeps.filter((node) => olddeps.indexOf(node) === -1);
-    const deletions = olddeps.filter((node) => newdeps.indexOf(node) === -1);
-    additions.forEach((d) => d._addDependent(this));
-    deletions.forEach((d) => d._removeDependent(this));
+    const additions = newdeps.filter(node => olddeps.indexOf(node) === -1);
+    const deletions = olddeps.filter(node => newdeps.indexOf(node) === -1);
+    olddeps.forEach(d => d._removeDependent(this));
+    newdeps.forEach(d => d._addDependent(this));
     this.dependencies = newdeps;
     return [additions, deletions];
   }
