Skip to content

Rebased to graphhopper master and current ios  #46

Closed
@ghost

Description

Hi, I was working on updating the IOS integration to master. I managed to compile and run and plan a route on a quite recent version of graphhopper.

In order to minimize the porting changes I rebased my efforts to graphhopper "master" and made good progress until I hit a blocker.

My repos are https://github.com/oflebbe/graphhopper-ios and https://github.com/oflebbe/graphhopper (branch ios_compat_new) . The patch to graphhopper is really minimalistic right now.

graphhopper-ios is rather large, since I had to upgrade dependencies.

The code compiles, links, runs ... and dies at route planning with the message

[java.lang.IllegalArgumentException: You need to specify a profile to perform a routing request, see #1958]
I do not understand what exactly needs to be done, since the tests are rather convoluted at that point and not easily adopted to IOS.

Question 1) I doublechecked with the current Android app and it does not create a ProfileConfig as well.( Does this code really work on Android ?) What would be the correct Java Code to add to Graphhopper initialization or to GHRequest , to fit the default-example.yaml from graphhopper ? (Do I need to add ProfileConfig for CH and LM as well ?) what would be the names ?

This is one obstacle to be solved for submitting a PR to merge it to graphhopper-ios, if you like to merge it :
Question 2) What are the prerequistes for merging , if you care ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions