feat(compiler): Allow exporting the function table #1870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
requested review from
jozanza,
marcusroberts,
ospencer and
peblair
as code owners
Accidently duplicated the start section tests
Member
Author
|
Converting to draft as this might need some more thought. given that grain closures make functions in the function table a little harder. |
Member
Author
|
I am closing this pr, I think the feature would still be beneficial eventually but more thought needs to go into it and as we removed the linker with the object file change the implementation here won't be much help in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to play arround with https://github.com/contextfreeinfo/taca/tree/main I noticed that it uses the function table for callbacks which grain didnt support. This pr adds the ability to run the compiler with the
--export-function-tableflag which takes anameas a string. which causes the function table to be exported under the given name during linking. This is primarily useful for writing foreign bindings.