Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Organize tagging functions for Int32, Int64, Uint32, Uint64, WasmF32, WasmF64 #2157

Open
spotandjake opened this issue Sep 16, 2024 · 0 comments
Open

Organize tagging functions for Int32, Int64, Uint32, Uint64, WasmF32, WasmF64 #2157

spotandjake opened this issue Sep 16, 2024 · 0 comments
Labels
good second issue Great issues if you're familiar with contributing to Grain. runtime

Comments

@spotandjake
Copy link
Member

spotandjake commented Sep 16, 2024 •
edited
Loading

We currently have tagging and untagging functions for the various stack allocated number types in DataStructures it would probably be beneificial if we added functions for the heap allocated ones as well. As we are not really tagging here it might make more sense to use something like loadInt32, loadInt64.
These functions currently do exist in runtime/unsafe/conv it might make sense to re-export these from DataStructures so we have a single file giving us all of our primitive conversion functions.
@spotandjake spotandjake added runtime good second issue Great issues if you're familiar with contributing to Grain. labels Sep 16, 2024
@spotandjake spotandjake changed the title Add tagging functions for Int32, Int64, Uint32, Uint64, WasmF32, WasmF64 Organize tagging functions for Int32, Int64, Uint32, Uint64, WasmF32, WasmF64 Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good second issue Great issues if you're familiar with contributing to Grain. runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spotandjake