Skip to content

Grafana 5.0: Enable permissions for dashboard folder and dashboards #10275

Closed

Description

There is a hidden, unused modal component for dashboard permissions.

This needs to be converted to a page component that can be used for the new dashboard folder page and for the new combined settings page for dashboards.

Fix route permissions so that they do not conflict with new permissions system:

  • Annotations route - remove require editor role and replace with permissions check with fallback to role check
  • Dashboard post/delete route - remove req editor role on route and test that the permission system works as it should with default permissions
  • alert-notifications route - investigate if req editor role is needed (is needed)
  • alert routes - investigate if req editor role is needed (only pause requires editor role

Other fixes:

  • when saving new dashboards, check the parent folder for permission to save.
  • filter out folders from folder picker that the user does not have permission to save in.
  • hide create dashboard cta on dashboard folder page if user does not have permission to create a new dashboard in that folder.
  • hide new dashboard button on dashboard folder page if user does not have permission to create a new dashboard in that folder.
  • Change permissions select to new component with description for each item in the dropdown (maybe based on react select component)
  • "inherited from folder" text should say which folder
  • "inherited from folder" for dashboards in root should have a different text
  • investigate removing inherited permissions for a folder (and document)
  • Add title to folder permissions page
  • Show warning if user tries to remove their own access to a folder.
  • Remove "Update Permissions" button and save on every change.
  • Add readonly Admin row to permissions (to show that Admins always have admin permission)
  • Disable the pause and settings buttons for alerts in the alert list that the user does not have permission to view/edit.
  • Update permissions page to the React version in dashboard settings and remove old Angular version of the page.
  • Move help text into popover.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions