core: fix serverResponseTime typo in network-server-latency #9388
Conversation
angelogulina
requested review from
brendankenny,
patrickhulce and
paulirish
as code owners
angelogulina
changed the title
There was a problem hiding this comment.
Yikes, great catch @angelogulina thank you so much for the PR!
While this is technically a "breaking" change, it's so egregiously a bug that I'm 👍 with shipping in next minor. I also have to believe you're the first person that has actually tried to use this with a fixed string, so pretty low risk of breaking folks.
(for core team, the only usage of this in DZL is automatically populating the diagnostic pool and the string is not hard coded, i.e. the label is just generated with _.startCase(key) and just haven't caught the typo)
patrickhulce
changed the title
patrickhulce
changed the title
| @@ -4991,4 +4991,4 @@ | |||
| "total": 12345.6789 | |||
| }, | |||
| "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3358.0 Safari/537.36" | |||
| } | |||
There was a problem hiding this comment.
I wonder why this happened? Unix vs. windows proto diff maybe?
There was a problem hiding this comment.
some people have editor settings for this, though maybe you'd have to be committing through your editor for those to be triggered for these files?
Summary
This fixes a typo for
network-server-latency, which has currentlyserverReponseTimeinstead ofserverResponseTime(and maybe cause bugs when trying to get some values out of the JSON).