core(domstats): support an empty html body #9340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
commented
Jul 10, 2019
| let deepestElement = null; | ||
| let maxDepth = 0; | ||
| let maxWidth = 0; | ||
| let maxDepth = -1; |
Contributor
Author
There was a problem hiding this comment.
maxDepth doesn't need to change (<body> counts as depth 1 which is > 0), but it seemed weird not to change it as well :)
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice, should we get a smoketest in there?
Contributor
Author
It is unfortunate to not have a regression test, but it felt like overkill to add a smoke test (+5 seconds to all future test runs?) for a trivial corner case of a single audit that can only occur with completely empty pages... Where do you fall on that trade off? |
patrickhulce
approved these changes
Jul 10, 2019
Collaborator
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
You know I fall into the ship it camp, it just felt like something @brendankenny would say 😉
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #8725
The issue was that domstats starts with a 0 as the max number of children seen as the base case, an empty
<body>has 0 children (which isn't more than 0), and soparentWithMostChildrenstayed asnull.Instead we start with a -1 so that there will always be at least
<body>in there. Could have also gone with a>=check, but that changes it soparentWithMostChildrenis the last one seen if there are ties, which would sort of be a breaking change. This seemed better (and more the original intent, I guess).