Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: suggest uploading issue repro #9217

Merged
merged 4 commits into from
Jun 18, 2019
Merged

misc: suggest uploading issue repro #9217

merged 4 commits into from
Jun 18, 2019

Conversation

connorjclark
Copy link
Collaborator

No description provided.

@vercel vercel bot temporarily deployed to staging June 16, 2019 21:58 Inactive
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we'll see how well this sticks :)

.github/ISSUE_TEMPLATE/Bug_report.md Outdated Show resolved Hide resolved
@brendankenny
Copy link
Member

brendankenny commented Jun 17, 2019

Endorsing a particular product feels off to me, but we do use surge in at least one link in our docs. But what about glitch or others? (edit: or jsbin as @patrickhulce added)

At the least maybe reword so it's more of "here's the goal, and here's some suggested service(s) that can accomplish the goal"

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@connorjclark connorjclark changed the title misc: suggest uploading issue repro to surge.sh misc: suggest uploading issue repro Jun 17, 2019
@connorjclark
Copy link
Collaborator Author

@brendankenny ok. although I am unfamiliar with glitch, it doesn't seem like a fast tool for uploading code snippets, so I left it out.

@paulirish paulirish merged commit 5c65f06 into master Jun 18, 2019
@paulirish paulirish deleted the connorjclark-patch-1 branch June 18, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants