-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
misc: suggest uploading issue repro #9217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, we'll see how well this sticks :)
Endorsing a particular product feels off to me, but we do use surge in at least one link in our docs. But what about glitch or others? (edit: or jsbin as @patrickhulce added) At the least maybe reword so it's more of "here's the goal, and here's some suggested service(s) that can accomplish the goal" |
Co-Authored-By: Patrick Hulce <[email protected]>
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
@brendankenny ok. although I am unfamiliar with glitch, it doesn't seem like a fast tool for uploading code snippets, so I left it out. |
No description provided.