report: only print light theme #9173
Conversation
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
nice this worked out nicely and super cleanly!
worth a test?
| * @param {Function} cb | ||
| */ | ||
| _setLightThemeTemporarily(cb) { | ||
| const isDark = this._dom.find('.lh-vars', this._document).classList.contains('dark'); |
There was a problem hiding this comment.
yikes 😆 I wonder if we should use a variable or something in ReportUIFeatures state...
misread and realized this was testing classList and not textContent but a function or something that encapsulates this might be nice
brendankenny
left a comment
brendankenny
left a comment
There was a problem hiding this comment.
seems like what @media print was made for? We couldn't do expansion that way because audit content is in <details> elements, but seems like this would be possible?
|
How could a media rule unapply the is EDIT: yeah that works |
217b768 :P |
|
|
patrickhulce
left a comment
patrickhulce
left a comment
There was a problem hiding this comment.
all kidding aside, I do think @hoten 's old approach would be a great candidate for the expansion business to avoid mucking up the selection state!
4 participants
Fixes #9155.