Skip to content

Conversation

@patrickhulce
Copy link
Collaborator

Summary

I ended up commenting out the smoke parts because it kept flaking

Right now it runs it 3x if it fails. I'm not a huge fan of this personally. Seems like a really bad scenario if our smokes flake this much even locally now :( (probably #9107 stuff?)

I was confused on this part, because I think you can't page up/down to see the whole diff.

Yeah sorry I forgot not all shells support mouse scroll, fixed! :)

Docs should instruct building / packaging from the pristine checkout

Done!

clean-pristine.sh is a thing but doesn't seem to be referenced anywhere.

The steps it does are automatically run in prepare-pristine.sh now and while it was handy to have around during testing I agree its existence is a bit confusing, removed.

Related Issues/PRs
closes #9091

Copy link
Collaborator

@connorjclark connorjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patrickhulce patrickhulce merged commit 4bd3a58 into master Jun 4, 2019
@patrickhulce patrickhulce deleted the better_release_scripts branch June 4, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Release script feedback

3 participants