-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add OpenTelemetry Tracing support as a preview feature #1288
Conversation
* feat: introduce OpenTelemetry Tracing decorators * update test coverage * add tests, update fixture * update noxfile, extras; remove print * update unit test * review comments
* feat: OTel tracing media ops initial instrumentation * use download class name as span name * avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a tiny comment.
I'd let someone else also take a look since I don't know much about it.
@@ -0,0 +1,100 @@ | |||
"""Manages OpenTelemetry tracing span creation and handling.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright and License missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Neha! I've added the copyright notice.
This adds OpenTelemetry Tracing support as a preview feature, and is subject to change before GA launch.
To enable OpenTelemetry tracing in the python storage client, please refer to the readme for instructions and samples. Feel free to submit bugs and general feedback by opening a github issue.