Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add OpenTelemetry Tracing support as a preview feature #1288

Merged
merged 6 commits into from
Jun 26, 2024
Merged

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Jun 14, 2024

This adds OpenTelemetry Tracing support as a preview feature, and is subject to change before GA launch.

To enable OpenTelemetry tracing in the python storage client, please refer to the readme for instructions and samples. Feel free to submit bugs and general feedback by opening a github issue.

* feat: introduce OpenTelemetry Tracing decorators

* update test coverage

* add tests, update fixture

* update noxfile, extras; remove print

* update unit test

* review comments
* feat: instrument metadata ops with Otel tracing

* update README plus test

* update decorator name per review session

* fix typo in readme
* feat: OTel tracing media ops initial instrumentation

* use download class name as span name

* avoid asserting filtered warnings from otel per open-telemetry/opentelemetry-python#3164
@cojenco cojenco added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 14, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Jun 15, 2024
@danielduhh danielduhh added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 17, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 17, 2024
@cojenco cojenco marked this pull request as ready for review June 18, 2024 21:05
@cojenco cojenco requested review from a team as code owners June 18, 2024 21:05
Copy link

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a tiny comment.
I'd let someone else also take a look since I don't know much about it.

@@ -0,0 +1,100 @@
"""Manages OpenTelemetry tracing span creation and handling."""

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copyright and License missing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Neha! I've added the copyright notice.

@danielduhh danielduhh requested a review from andrewsg June 21, 2024 16:55
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 21, 2024
README.rst Outdated Show resolved Hide resolved
google/cloud/storage/_opentelemetry_tracing.py Outdated Show resolved Hide resolved
@cojenco cojenco requested a review from andrewsg June 26, 2024 21:11
@cojenco cojenco merged commit c2ab0e0 into main Jun 26, 2024
15 checks passed
@cojenco cojenco deleted the otel-trace branch June 26, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/python-storage API. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants