Skip to content

Conversation

@parthea
Copy link
Contributor

@parthea parthea commented Mar 13, 2024

This is related to protocolbuffers/protobuf@2699579 and the protobuf 5.x release candidates
https://pypi.org/project/protobuf/5.26.0rc2/
https://pypi.org/project/protobuf/5.26.0rc3/

Similar to googleapis/gapic-generator-python#1936

See googleapis/gapic-generator-python#1935 (comment)

This should resolve the failure with Kokoro Prerelease Dependencies in #846.

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/python-logging API. labels Mar 13, 2024
@parthea parthea changed the title fix: remove usage in including_default_value_fields to prepare for protobuf 5.x fix: remove usage of including_default_value_fields to prepare for protobuf 5.x Mar 13, 2024
@parthea parthea changed the title fix: remove usage of including_default_value_fields to prepare for protobuf 5.x fix: fix TypeError: MessageToJson() got an unexpected keyword argument 'including_default_value_fields' Mar 13, 2024
@parthea parthea marked this pull request as ready for review March 13, 2024 14:07
@parthea parthea requested review from a team as code owners March 13, 2024 14:07
@parthea parthea requested a review from cindy-peng March 13, 2024 14:07
@gkevinzheng gkevinzheng merged commit 66a534d into main Mar 13, 2024
@gkevinzheng gkevinzheng deleted the prepare-for-protobuf-5 branch March 13, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants