-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Added documentation for Django/Flask integrations and dictConfig #848
Conversation
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few small suggestions
"handlers": { | ||
"cloud_logging": { | ||
"class": "google.cloud.logging.handlers.CloudLoggingHandler", | ||
"client": client, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe the client setup should be part of the sample?
docs/web-framework-integration.rst
Outdated
|
||
Django integration has been tested to work with each of the Django/Python versions listed `here <https://docs.djangoproject.com/en/5.0/faq/install/#what-python-version-can-i-use-with-django>`_. | ||
To enable Django integration, add `google.cloud.logging_v2.handlers.middleware.RequestMiddleware` to the list of `MIDDLEWARE` | ||
in your settings file. Also be sure to :doc:`set up logging </std-lib-integration>` in your settings file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a link like this to "settings file"? https://docs.djangoproject.com/en/5.0/topics/settings/
dictConfig
Fixes #429
Fixes #844