-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Handle exceptions raised when fetching Django request data #758
fix: Handle exceptions raised when fetching Django request data #758
Conversation
Hi, I have tested this on the App Engine app that was showing errors, and I no longer see the errors. Which is a good thing. I'm not sure that my fix of catching any
Also I figured setting |
6899d60
to
4675a4d
Compare
e99d194
to
ab1bc52
Compare
The Django helper calls `request.build_absolute_uri()`, but that may raise a DisallowedHost exception itself. Instead we catch any exception and log `None` as the URL.
ab1bc52
to
5b4c719
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this together!
The Django helper calls
request.build_absolute_uri()
, but that may raise a DisallowedHost exception itself. Instead we catch any exception and logNone
as the URL.Fixes #757