Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support Django asgi middleware #625

Merged
merged 10 commits into from
Oct 6, 2022
Merged

feat: support Django asgi middleware #625

merged 10 commits into from
Oct 6, 2022

Conversation

daniel-sanche
Copy link
Contributor

Fixes #607

This PR updates our old deprecated MiddlewareMixin Django middleware to use the current best practices, which fixes a crashing bug when using modern asgi webservers

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/python-logging API. labels Sep 9, 2022
@losalex losalex added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 28, 2022
@daniel-sanche daniel-sanche changed the title [DRAFT] feat: support Django asgi middleware feat: support Django asgi middleware Oct 3, 2022
@daniel-sanche daniel-sanche marked this pull request as ready for review October 3, 2022 17:39
@daniel-sanche daniel-sanche requested review from a team as code owners October 3, 2022 17:39
glasnt
glasnt approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@glasnt glasnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested applying these fixes on Django deployed on Cloud Run and App Engine. Works as expected on each platform.

losalex
losalex approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@losalex losalex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-sanche daniel-sanche merged commit f52b3aa into main Oct 6, 2022
@daniel-sanche daniel-sanche deleted the asgi-fix branch October 6, 2022 22:04
@release-please release-please bot mentioned this pull request Oct 6, 2022
Merged
@daniel-sanche daniel-sanche mentioned this pull request Nov 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@losalex losalex losalex approved these changes

@glasnt glasnt glasnt approved these changes

Assignees

@daniel-sanche daniel-sanche

Labels
api: logging Issues related to the googleapis/python-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release. size: s Pull request size is small. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for asgi django apps
3 participants
@daniel-sanche @glasnt @losalex