Skip to content

feat: add prefer_bqstorage_client option for Connection #1945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Linchin merged 1 commit into from
Jun 10, 2024
Merged

feat: add prefer_bqstorage_client option for Connection #1945

Linchin merged 1 commit into from
Jun 10, 2024

Conversation

@Linchin
Copy link
Contributor

@Linchin Linchin commented Jun 4, 2024 •
edited
Loading

This gives users the option to not use the Storage client if they prefer the REST client.

Fixes #1920 🦕

@Linchin Linchin requested review from a team as code owners June 4, 2024 23:23
@Linchin Linchin requested a review from shollyman June 4, 2024 23:23
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jun 4, 2024
chalmerlowe
chalmerlowe approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QUESTION: Would we consider this a breaking change since we are moving to having a default setting of True instead of False which is what I feel like the current setting is.

I am approving this, pending an answer to the above question.
Would be happy to get in a chat OR a meeting to discuss, as need. be.

@Linchin
Copy link
Contributor Author

Linchin commented Jun 10, 2024

QUESTION: Would we consider this a breaking change since we are moving to having a default setting of True instead of False which is what I feel like the current setting is.

I am approving this, pending an answer to the above question. Would be happy to get in a chat OR a meeting to discuss, as need. be.

Thanks for the question! The default behavior in the past is True. As in #1920, the customer couldn't disable the storage client unless they uninstall the package altogether.

@Linchin Linchin merged commit bfdeb3f into googleapis:main Jun 10, 2024
@release-please release-please bot mentioned this pull request Jun 10, 2024
Merged
This was referenced Jun 25, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman was automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow enabling/disabling the storage API on a per-connection basis

2 participants

@Linchin @chalmerlowe