Skip to content

fix: retry is_job_done on ConnectionError #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Linchin merged 1 commit into from
May 23, 2024
Merged

fix: retry is_job_done on ConnectionError #1930

Linchin merged 1 commit into from
May 23, 2024

Conversation

@tswast
Copy link
Contributor

@tswast tswast commented May 23, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1929 🦕

@tswast tswast requested review from a team as code owners May 23, 2024 16:51
@tswast tswast requested a review from shollyman May 23, 2024 16:51
@tswast tswast mentioned this pull request May 23, 2024
Closed
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels May 23, 2024
@tswast tswast requested a review from Linchin May 23, 2024 19:07
Linchin
Linchin approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Linchin Linchin merged commit 4f72723 into main May 23, 2024
@Linchin Linchin deleted the issue1929-retry-connectionerror branch May 23, 2024 19:48
@Linchin Linchin assigned Linchin and unassigned PhongChuong May 23, 2024
@release-please release-please bot mentioned this pull request May 21, 2024
Merged
This was referenced Jun 11, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Linchin Linchin Linchin approved these changes

@shollyman shollyman Awaiting requested review from shollyman shollyman was automatically assigned from googleapis/api-bigquery

Assignees

@Linchin Linchin

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Retry requests.exceptions.ConnectionError

3 participants

@tswast @Linchin @PhongChuong