Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: creates linting-typing.cfg in presubmit #1881

Merged
merged 17 commits into from
Apr 3, 2024
Merged

fix: creates linting-typing.cfg in presubmit #1881

merged 17 commits into from
Apr 3, 2024

Conversation

chalmerlowe
Copy link
Collaborator

This PR creates a new configuration file in the .kokoro/presubmit folder.
The intent is to eventually move multiple checks out of the baseline Kokoro check and put them into their own Kokoro linting-typing:

The checks we are moving out include:

Typing:

  • mypy
  • mypy_samples
  • pytype

Linting/formatting:

  • lint
  • lint_setup_py
  • blacken

@chalmerlowe chalmerlowe requested review from a team as code owners March 29, 2024 11:19
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

conventional-commit-lint-gcf bot commented Mar 29, 2024 •
edited
Loading

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Mar 29, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Mar 29, 2024
@chalmerlowe
Copy link
Collaborator Author

chalmerlowe commented Mar 29, 2024 •
edited
Loading

There is an internal Google CL (#618137967) to update the allowed env vars for this repository.
Once that gets approved, we should be able to confirm that this PR runs and determine what, if any time-savings are achieved by parallelizing these tests.

shollyman
shollyman approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for simplifying this a bit!

@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 29, 2024
chalmerlowe
chalmerlowe commented Mar 29, 2024
View reviewed changes
Copy link
Collaborator Author

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the comments.

noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@chalmerlowe chalmerlowe added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 2, 2024
@chalmerlowe chalmerlowe added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 2, 2024
@chalmerlowe chalmerlowe merged commit c852c15 into main Apr 3, 2024
21 checks passed
@chalmerlowe chalmerlowe deleted the add-linting-typing-kokoro branch April 3, 2024 11:09
@release-please release-please bot mentioned this pull request Apr 3, 2024
Merged
This was referenced Apr 23, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@PhongChuong PhongChuong Awaiting requested review from PhongChuong PhongChuong is a code owner automatically assigned from googleapis/api-bigquery

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chalmerlowe @shollyman @yoshi-kokoro