feat: add fields parameter to set_iam_policy for consistency with update methods
#1872
+188
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
product-auto-label
bot
added
size: m
tswast
commented
Mar 26, 2024
| def test_create_iam_policy(table_id: str): | ||
| your_table_id = table_id | ||
|
|
||
| # [START bigquery_create_iam_policy] |
There was a problem hiding this comment.
tswast
commented
Mar 26, 2024
| @@ -1485,33 +1484,6 @@ def test_copy_table(self): | |||
| got_rows = self._fetch_single_page(dest_table) | |||
| self.assertTrue(len(got_rows) > 0) | |||
|
|
|||
| def test_get_set_iam_policy(self): | |||
There was a problem hiding this comment.
This test is now redundant with a code sample which serves the same purpose with regards to testing.
This was referenced Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
get_iam_policyandset_iam_policyget_iam_policyandset_iam_policyThank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1871 🦕