Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support nullable boolean and Int64 dtypes in insert_rows_from_dataframe #1816

Merged
merged 1 commit into from
Feb 12, 2024
Merged

feat: support nullable boolean and Int64 dtypes in insert_rows_from_dataframe #1816

merged 1 commit into from
Feb 12, 2024

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Feb 9, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1815
🦕

@tswast tswast requested review from a team as code owners February 9, 2024 22:54
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Feb 9, 2024
@tswast tswast requested review from chalmerlowe and Linchin and removed request for nayaknishant February 9, 2024 22:54
Linchin
Linchin approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@Linchin Linchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this doesn't just apply to Int64, but also the rest of nullable int types: Int64, Int32, Int16, Int8, UInt64, UInt32, UInt16 and UInt8.

@Linchin Linchin merged commit ab0cf4c into main Feb 12, 2024
22 checks passed
@Linchin Linchin deleted the tswast-insert_rows_from_dataframe branch February 12, 2024 19:46
@release-please release-please bot mentioned this pull request Feb 12, 2024
Merged
@tswast tswast mentioned this pull request Mar 4, 2024
Open
4 tasks
This was referenced Mar 12, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

insert_rows_from_dataframe doesn't support nullable boolean or nullable Int64 dtypes
2 participants
@tswast @Linchin