-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: query_and_wait
now retains unknown query configuration _properties
#1793
Conversation
query_and_wait
now retains unknown query configuration `_prope…query_and_wait
now retains unknown query configuration _properties
Could you tell me more about the rationale of keeping unknown config fields? |
Two reasons: (1) as you can see from the removal of this code:
it allows for a cleaner conversion from query job insert request to jobs.query request. (2) It allows for customers who want access to features that are in preview an not yet implemented in the client library to set REST API properties via setting |
That's great to know! Thank you |
fix: raise
ValueError
inquery_and_wait
with wrongjob_config
typeThank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1792
🦕