Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: update client_query_w_named_params.py to use query_and_wait API #1782

Merged
merged 9 commits into from
Feb 12, 2024
Merged

docs: update client_query_w_named_params.py to use query_and_wait API #1782

merged 9 commits into from
Feb 12, 2024

Conversation

SalemJorden
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery API. labels Jan 16, 2024
@SalemJorden SalemJorden force-pushed the salem_querywnamedparams branch from a4805ac to a7de649 Compare January 16, 2024 21:36
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 18, 2024
@chalmerlowe chalmerlowe added the type: docs Improvement to the documentation for an API. label Jan 22, 2024
@kiraksi kiraksi self-requested a review January 25, 2024 09:45
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 6, 2024
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2024
@kiraksi kiraksi marked this pull request as ready for review February 12, 2024 19:03
@kiraksi kiraksi requested review from a team as code owners February 12, 2024 19:03
@kiraksi kiraksi requested review from parthea and removed request for parthea February 12, 2024 19:03
kiraksi
kiraksi approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@kiraksi kiraksi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

samples/client_query_w_named_params.py Outdated Show resolved Hide resolved
@kiraksi kiraksi added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 12, 2024
@kiraksi kiraksi enabled auto-merge (squash) February 12, 2024 23:06
@kiraksi kiraksi merged commit 89dfcb6 into googleapis:main Feb 12, 2024
18 of 19 checks passed
@release-please release-please bot mentioned this pull request Feb 12, 2024
Merged
This was referenced Mar 12, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiraksi kiraksi kiraksi approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SalemJorden @kiraksi @chalmerlowe @yoshi-kokoro